Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON parsing should detect embedded \0 values #759

Merged
merged 3 commits into from Aug 5, 2023
Merged

JSON parsing should detect embedded \0 values #759

merged 3 commits into from Aug 5, 2023
+12 −0

Commits on Aug 1, 2023

  1. Don't skip past \0 when parsing JSON objects. 

    A better solution might be to use -1 instead 0 to represent EOF everywhere,
which of course means changing `char` variables to `int`. The solution here is
enough to solve the immediate problem, though.

Fixes stleary#758.
    @eamonnmcmanus
    eamonnmcmanus committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    c8a9e15 View commit details
    Browse the repository at this point in the history

  2. Fix indentation in test.

    @eamonnmcmanus
    eamonnmcmanus committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    b6ff0db View commit details
    Browse the repository at this point in the history

  3. Apply simplification suggested by @johnjaylward.

    @eamonnmcmanus
    eamonnmcmanus committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    2a4bc34 View commit details
    Browse the repository at this point in the history