Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 682 JSONString similarity #683

Merged
merged 2 commits into from Aug 27, 2022

Conversation

spaffrath
Copy link
Contributor

@spaffrath spaffrath commented Aug 5, 2022

For Issue #682.

What problem does this code solve?
The similar methods of JSONObject and JSONArray did not evaluate two equivalent JSONString objects to true.

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, new unit tests were added.

Was any code refactored in this commit?
No

Review status:
APPROVED

@spaffrath
Copy link
Contributor Author

Something seems to be wrong in the CI. Not sure what but cannot see how these changes are related. @johnjaylward Do you know?

@johnjaylward
Copy link
Contributor

@stleary it looks like we may have an incorrect version of something in the maven build configuration:

2022-08-05T19:07:53.5945505Z [WARNING] Error injecting: org.apache.maven.plugins.surefire.report.SurefireReportOnlyMojo
2022-08-05T19:07:53.5946593Z java.lang.TypeNotPresentException: Type org.apache.maven.plugins.surefire.report.SurefireReportOnlyMojo not present

2022-08-05T19:07:53.6075845Z Caused by: java.lang.UnsupportedClassVersionError: org/apache/maven/plugins/surefire/report/SurefireReportOnlyMojo : Unsupported major.minor version 52.0

@spaffrath you are correct it's not related to the changes, however you may be able to fix the issue by updating the POM.xml. It looks like one or more of the plugins is having a version conflict.

@stleary
Copy link
Owner

stleary commented Aug 10, 2022

I can take a look at this tonight.

@stleary
Copy link
Owner

stleary commented Aug 13, 2022

See #684
You can make the same change on your branch, or wait for the merge to master, and then merge master to your branch and try again.

@stleary
Copy link
Owner

stleary commented Aug 23, 2022

Starting 3 day comment window

@stleary stleary merged commit 346fb26 into stleary:master Aug 27, 2022
@spaffrath spaffrath deleted the Issue_682_JSONString_similarity branch August 27, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants