Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIを設定 #38
CIを設定 #38
Changes from 6 commits
11581cb
5536678
6422f75
21ee16c
ff5d809
ef34a14
cdcc7cc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build checkはあるんですが、lintがないようです:eyes:
一応VSCode上でPrettierによる保存時フォーマットは有効になってはいると思うものの、
CIでもチェックしたほうがいいと思うのですがどうでしょうか?
@para7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cotton-alta
確かに。入れるべきかもしれません
@Percy08-dev
後ほど実行コマンドお送りします
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
今日フロント課題のセッティング等の方をやってたので明日コマンド作成します…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Percy08-dev
お待たせしました。
先ほど新しくプルリクを発行してマージしましたので、取り込んで以下の実行をお願いします!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こちら申し訳ないのですが、github pagesが無料プランだと使えないようなので、一旦コメントアウトしておいてもらえますか:bow:(カタログのデプロイ先を別issueで検討したいと思います)
合わせて以下のようにTODOコメントも追記しておいていただけるとありがたいです:pray:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cotton-alta
プライベートリポジトリだから、ですよねたぶん。
ブランチ保護もそうですし、公開にして解決するなら将来的に公開予定ですしもう出しちゃってもいいのではないかという気もしてきたのですがどうなんでしょう。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
公開にしちゃいますかー
discordの方で一応問題ないか確認してから変更させてください:pray:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こちらの問題は解決したので、忘れてもらって大丈夫です
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
golangci/golangci-lint-action#704