New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supports of conversion between string and enum #664

Closed

yestyle wants to merge 2 commits into stepancheg:v3.2 from yestyle:v3.2

Contributor

yestyle commented Jan 27, 2023

To support converting from &str to Enum and converting from Enum to String, add from_str() and implement Display for trait Enum respectively.

yestyle added 2 commits

October 17, 2022 15:55


          Implement Display for enums in protobuf-codegen


          Add from_str() for trait Enum

32f6ff3

Owner

stepancheg commented Oct 2, 2023

Merged with changes:

no Display (I'm not 100% sure it should be)
use string value directly without stringify! call
use proto enum name instead of rust name in match (probably it is the same everywhere, but safer this way)

Thanks!

stepancheg closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment