Build binaries for macOS amd64 and arm64 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
commented
Apr 24, 2024
dmkozh
approved these changes
Apr 24, 2024
|
According to this post by GitHub in January the So I've updated this PR to build the macos x86 binaries using |
leighmcculloch
commented
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Build binaries for macOS amd64 and arm64
Why
I started to see builds fail because
macos-latestappears to now map tomacos-14-armrather thanmacos-14. An example of a build I saw fail is: https://github.com/stellar/rs-soroban-sdk/actions/runs/8815533346/job/24197683380?pr=1261