Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw if no version is specified in dependency's package.json #82

Merged
merged 1 commit into from
Aug 3, 2023
Merged

throw if no version is specified in dependency's package.json #82

merged 1 commit into from
Aug 3, 2023

Conversation

cafreeman
Copy link
Contributor

Closes #81

rwjblue
rwjblue approved these changes Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@rwjblue rwjblue left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this change, fixturify-project silently ignores deps/devDeps that are missing a version field in package.json.

@rwjblue rwjblue added the bug Something isn't working label Mar 28, 2023
@ef4 ef4 merged commit 69d069e into stefanpenner:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fromDir drops linked dependencies if they don't specify a version number
3 participants
@cafreeman @rwjblue @ef4