Fix Docker Build (issue with go-sqlite3) #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemand771
approved these changes
Dec 25, 2023
|
latest failure is my fault, I updated |
jemand771
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: In a new version of Alpine they updated an internal library which then broke the Go library
mattn/go-sqlite3. Golang automatically pulled in this new version of alpine when rebuilding the1.20release, which is causing the builds to now fail.Short Term Fix: By pinning the image to
1.20.0-alpineinstead of just1.20-alpinewe are grabbing an older built image that does not experience this issue. This maintains compatibility with all current code and requires no other changes.Long Term Fix: Update the library version for
mattn/go-sqlite3to one that includes the patch.See here for more detail: mattn/go-sqlite3#1177 (comment)
Changelog
Fixed
Changed
golang:1.20.0-alpine.