Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our base test class, we have a couple of mocks that fake the version and nav being built.
In versions of Mockery prior to 1.5.1, this would add an assertion count, but we didn't care about it actually counting it, so we negated it.
For example:
In Mockery 1.5.1, they fixed it so that if you aren't actually counting the number of times the method is called, it doesn't consider it an assertion. mockery/mockery#1180
So now our tests can go into the negative.
We could bump the mockery requirement to 1.5.1 and remove the
$this->addToAssertionCount(-1)
, but it's a bit hairy with all the different versions of Laravel/PHP/etc we test with. The simpler solution was this PR, where we add azeroOrMoreTimes
expectation. That'll make sure it gets counted, then we can continue to un-count it.