Fixed comparison at bin/cmd
#1822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Thanks for opening this pull request! You're awesome. |
|
Thanks @Rudxain 🙏 I will hold off on merging this as I just did a rewrite to make use of It also helps checking that the version checked against is actually the intended version to check against, as it in this case actually should be This also relates to #1828 |
|
Ok. So, should I close the PR? Is it useful to keep it open? |
|
Let’s leave it open for now |
|
Fixed by #1828 with inspiration from this PR, thanks 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Changed a comparison within an expression to what it seemed correct. The expression after the
||tested for equality, but the>=op already did that, so I changed it to allow===to be usefulWhich issue (if any) does this pull request address?
None. I searched and didn't find anything similar
Is there anything you'd like reviewers to focus on?