Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support eslint v8 #193

Merged
merged 5 commits into from
Jan 7, 2022
Merged

feat: support eslint v8 #193

merged 5 commits into from
Jan 7, 2022

Conversation

theoludwig
Copy link
Member

@theoludwig theoludwig commented Oct 10, 2021

@theoludwig theoludwig self-assigned this Oct 10, 2021
@theoludwig theoludwig marked this pull request as draft October 10, 2021 07:55
@voxpelli
Copy link
Member

eslint-plugin-import @ v2.25.0 supports ESLint 8

@voxpelli
Copy link
Member

@divlo Do you know if eslint-plugin-node requires an update? As its set to be compatible with all future versions of ESLint. Is ESLint 8 breaking it in any way?

@voxpelli
Copy link
Member

Should we consider adding any of the news eslint:recommended rules? Probably wait for a major after this one, right?

  • no-loss-of-precision
  • no-nonoctal-decimal-escape
  • no-unsafe-optional-chaining
  • no-useless-backreference

.eslintrc.json Outdated Show resolved Hide resolved
Only eslint-plugin-promise is complaining and blocking right now
@voxpelli voxpelli mentioned this pull request Oct 14, 2021
@voxpelli voxpelli added this to the 17.0.0 milestone Oct 14, 2021
@theoludwig
Copy link
Member Author

@divlo Do you know if eslint-plugin-node requires an update? As its set to be compatible with all future versions of ESLint. Is ESLint 8 breaking it in any way?

I don't know if there's something breaking with ESLint v8.
We should probably wait a reply to your comment, to see how it goes: mysticatea/eslint-plugin-node#294 (comment) @voxpelli

@theoludwig
Copy link
Member Author

Should we consider adding any of the news eslint:recommended rules? Probably wait for a major after this one, right?

  • no-loss-of-precision
  • no-nonoctal-decimal-escape
  • no-unsafe-optional-chaining
  • no-useless-backreference

Good idea! 👍
I think we can alreay include these new rules in the next major version as this PR will be released in a major version anyway.

But maybe just to make this PR small and separated, we could include these rules in another PR.

@voxpelli
Copy link
Member

Good idea! 👍 I think we can alreay include these new rules in the next major version as this PR will be released in a major version anyway.

But maybe just to make this PR small and separated, we could include these rules in another PR.

We should always run new rules against the ecosystem and see how much they break and try to get all fixed first, as #148 and #166 has slowly been doing.

Speaking of: Would be good to get the PR:s for standard/standard#1702 out so that we can ship that in preparation for ESLint 8, as a preemptive measure

@voxpelli
Copy link
Member

Does this affect us? (Mainly a note to self to check this) mysticatea/eslint-plugin-node#301

@voxpelli
Copy link
Member

Does this affect us? (Mainly a note to self to check this) mysticatea/eslint-plugin-node#301

Yes it does:

"node/process-exit-as-throw": "error",

@Nagarian
Copy link

It seems that eslint-plugin-promise as been updated to eslint 8 https://github.com/xjamundx/eslint-plugin-promise/blob/development/CHANGELOG.md

@J3m5
Copy link

J3m5 commented Dec 23, 2021

It seems that eslint-plugin-promise as been updated to eslint 8 https://github.com/xjamundx/eslint-plugin-promise/blob/development/CHANGELOG.md

Related issue: #200

@fmal
Copy link

fmal commented Dec 28, 2021

anything blocking this being merged now?

@theoludwig
Copy link
Member Author

anything blocking this being merged now?

Nothing is blocking, it needs reviews! 😄

@theoludwig theoludwig marked this pull request as ready for review December 28, 2021 13:19
@wesleytodd
Copy link

Not that my approval means much as a non-contributor, but I pointed my project at this branch and ran with eslint@8 and it worked great. Really excited to finally be able to use private class properties with standard 🥇! Thanks for the good work team!

@yoyo837
Copy link

yoyo837 commented Jan 6, 2022

Friendly ping... @divlo

@voxpelli
Copy link
Member

voxpelli commented Jan 6, 2022

It’s not Divlo but the rest of us maintainers that are a bit slow at reviewing this, I myself have been taking time of programming now during the Christmas holiday, but hope to get around to this one any day now

@voxpelli voxpelli self-requested a review January 6, 2022 11:51
@melroy89
Copy link

melroy89 commented Jan 7, 2022

Yes, finally please.

@voxpelli voxpelli merged commit 8457629 into master Jan 7, 2022
@voxpelli voxpelli deleted the feat/support-eslint-v8 branch January 7, 2022 17:04
@voxpelli
Copy link
Member

voxpelli commented Jan 7, 2022

I have now rolled a 17.0.0-0 prerelease of this.

You can install it using eslint-config-standard@next.

Being a pre-release, this one comes with no guarantees in regards to support / breaking changes etc. It exists to facilitate early feedback, from the wider community as well from our selves.

Next step now is to ship a prerelease of standard itself, to further validate the changes introduced here and minimize the risk for unintended breakage.

@voxpelli voxpelli mentioned this pull request Jan 7, 2022
14 tasks
@manuman94
Copy link

manuman94 commented Mar 31, 2022

Awesome! When will v17 stop being the @next to be the stable version?

@kleinfreund
Copy link

@manuman94 For information on this, please read #208 which tracks everything revolving around this process.

@manuman94
Copy link

Thank you! Sorry if this wasn't the place to ask. Greetings.

posva

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project