Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(helm): cover extraction of pull secrets from the default SA #8964

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

porridge
Copy link
Contributor

@porridge porridge commented Dec 8, 2023

Description

Now that we use a helmtest version with support for testing the lookup function, add test coverage for extraction of pull secret names from the default service account.

This was a warm-up for a fix to ROX-9156, but useful on its own.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

Testing Performed

Here I tell how I validated my change

CI is sufficient.

Reminder for reviewers

In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

Copy link

openshift-ci bot commented Dec 8, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@porridge
Copy link
Contributor Author

porridge commented Dec 8, 2023

/test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Dec 8, 2023

Images are ready for the commit at 22f8862.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.3.x-867-g22f8862f4d.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce62d07) 47.29% compared to head (d8304f4) 46.66%.
Report is 2 commits behind head on master.

❗ Current head d8304f4 differs from pull request most recent head 22f8862. Consider uploading reports for the commit 22f8862 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8964      +/-   ##
==========================================
- Coverage   47.29%   46.66%   -0.63%     
==========================================
  Files        2431     2394      -37     
  Lines      165064   160018    -5046     
==========================================
- Hits        78066    74675    -3391     
+ Misses      80548    79122    -1426     
+ Partials     6450     6221     -229     
Flag Coverage Δ
go-unit-tests 46.66% <ø> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@porridge porridge force-pushed the porridge/ROX-9156-test-with-lookup branch 3 times, most recently from 2606f5a to d8304f4 Compare December 19, 2023 07:53
@porridge porridge force-pushed the porridge/ROX-9156-test-with-lookup branch from d8304f4 to 22f8862 Compare January 25, 2024 08:05
@porridge porridge marked this pull request as ready for review January 25, 2024 08:11
@porridge
Copy link
Contributor Author

Not waiting for e2e tests, they are irrelevant to this change.

@porridge porridge enabled auto-merge (squash) January 25, 2024 08:54
@porridge porridge merged commit 9d545a5 into master Jan 25, 2024
57 of 65 checks passed
@porridge porridge deleted the porridge/ROX-9156-test-with-lookup branch January 25, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants