Fix setting labels manually on PRs that got labels from labeler. #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tag for build #273588 is 💻 For deploying this image using the dev scripts, run the following first: export MAIN_IMAGE_TAG='3.69.x-16-g8be26a4bfb'📦 You can also generate an installation bundle with: docker run -i --rm stackrox/main:3.69.x-16-g8be26a4bfb central generate interactive > bundle.zip🕹️ A |
janisz
approved these changes
Mar 4, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, somehow, its not possible sometimes to set labels on PRs which have labels added by labeler (they will be unchecked after some time). For reference, see this PR and this PR as examples for it not working.
There are, however, PRs where it is working, see this PR and this PR.
It appears that PRs that are created at the beginning with "non-labeler" labels are retaining them, afterwards it seems not to be possible to set those manually.
The issue I found were of this sort, where the labeler is preventing manual labels from being added. I'll try this workaround for now, unsetting the
sync-labelsproperty to check whether this will help.