Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a govulncheck job. #6345

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add a govulncheck job. #6345

wants to merge 2 commits into from

Conversation

porridge
Copy link
Contributor

@porridge porridge commented Jun 6, 2023

Description

https://go.dev/blog/vuln

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

Testing Performed

Relying on CI.

@porridge porridge requested a review from janisz June 6, 2023 09:18
@roxbot
Copy link
Contributor

roxbot commented Jun 6, 2023

Images are ready for the commit at 84df2d3.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.0.x-561-g2a012174ab.

Copy link
Contributor

@janisz janisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get back to it once we get rid of cgo and maybe this check will be added to golangci-lint

@janisz janisz mentioned this pull request Nov 17, 2023
5 tasks
@janisz
Copy link
Contributor

janisz commented Nov 17, 2023

So golangci will not integrate this check

I've created a PR that scans binaries not code and it's working

@porridge
Copy link
Contributor Author

porridge commented Nov 22, 2023

FTR it's currently crashing when scanning operator source.

@RTann
Copy link
Contributor

RTann commented Apr 27, 2024

@porridge can we close this? I believe we have it now :)

@porridge
Copy link
Contributor Author

@RTann govulncheck has at least two functionalities - source scanning and binary scanning, I believe the job we have is only using one of them (the latter). This is about the former one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants