ROX-8277 Fix malformed operator k8s client user-agent #5307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Images are ready for the commit at 01f56e5. To use with deploy scripts, first |
|
Closing as it is not currently possible to configure the leader-election user agent. kubernetes-sigs/controller-runtime#2243 |
|
How about fixing it upstream? |
|
@porridge yeah I can look at that. I see two issues
|
|
k8s-client PR: kubernetes/kubernetes#116801 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In certain cases, the UserAgent string sent by the operator to the kubernetes API is malformed. e.g.
^ see the
$Format/...suffixIt seems that the operator controller-runtime k8s client config is not used for all clients. For example, it seems that there is another k8s client instantiated for the leader election, which does not use the specified userAgent.