Add URL string union hook to better integrate url params with Tab components #5111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
5 tasks
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
|
Images are ready for the commit at caa4d47. To use with deploy scripts, first |
dvail
force-pushed
the
dv/pf-tab-url-hook
branch
from
735b6a0
to
56dd6fc
Compare
5 tasks
dvail
force-pushed
the
dv/ROX-15384-implement-image-single-page-summary
branch
from
81b074b
to
16bf636
Compare
dvail
force-pushed
the
dv/pf-tab-url-hook
branch
from
56dd6fc
to
f9fd6b1
Compare
Base automatically changed from
dv/ROX-15384-implement-image-single-page-summary
to
master
March 8, 2023 20:19
dvail
force-pushed
the
dv/pf-tab-url-hook
branch
from
f9fd6b1
to
bdaf3ad
Compare
pedrottimark
reviewed
Mar 9, 2023
| expect(initialValidResult.current[0]).toBe('Beta'); | ||
| expect(params.get('urlKey')).toBe('Beta'); | ||
|
|
||
| const { result: initialInvalidResult } = renderHook( |
There was a problem hiding this comment.
Is this the start of a separate test?
- See comment above: if the URL param already contains a valid value
- See comment below: when the URL param is invalid
There was a problem hiding this comment.
It can be: 'should use the default value when an invalid value is entered directly into the URL'
pedrottimark
approved these changes
Mar 9, 2023
dvail
force-pushed
the
dv/pf-tab-url-hook
branch
from
bdaf3ad
to
caa4d47
Compare
This was referenced Mar 9, 2023
vikin91
pushed a commit
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new hook that simplifies using a string union safely with a URL parameter. This should handle any case where we have a finite list of strings that are valid as a URL parameter, such as the current use case of having a known set of PF
Tabcomponents that we want to integrate with the URL.Even though this is for VM 2.0 right now, I'll add the @stackrox/ui team for awareness in case this is useful elsewhere.
This was actually a net removal of code, before comments and tests...
Checklist
If any of these don't apply, please comment below.
Testing Performed
Unit tests.
Cycle through tab clicks and ensure the correct tab is highlighted and that the URL parameter changes accordingly.
Visit the page via direct navigation with a non-default tab parameter selected and verify that the correct tab is selected.
Visit the page via direct navigation with an invalid parameter value and verify that the default tab is selected and parameter is changed to the default.