Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scannerdefs): some minor scannerdefinitions handler fixes #11166

Closed

Conversation

RTann
Copy link
Contributor

@RTann RTann commented May 18, 2024

Description

Mostly nits including some IDE warnings. One bug fix to account for offline blob retrieval error, which was previously ignored. Still have another IDE warning to look into.

Checklist

  • Investigated and inspected CI test results
  • [ ] Unit test and regression tests added
  • [ ] Evaluated and added CHANGELOG entry if required
  • [ ] Determined and documented upgrade steps
  • [ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

Testing Performed

Here I tell how I validated my change

No

Reminder for reviewers

In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

Copy link

openshift-ci bot commented May 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 4768397.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-727-g47683977aa.

@RTann RTann closed this May 23, 2024
@RTann RTann deleted the ross/scanner-defs-fixes branch May 23, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants