Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-24088: Adding ACSCS Default Email Integration form #11164

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

alwayshooin
Copy link
Contributor

image image BE integration tbd but the payload should look good

@alwayshooin alwayshooin requested a review from a team as a code owner May 17, 2024 23:46
@alwayshooin alwayshooin changed the base branch from master to ROX-24086 May 17, 2024 23:46
@rhacs-bot
Copy link
Contributor

rhacs-bot commented May 18, 2024

Images are ready for the commit at c2947ce.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-823-gc2947ce7ca.

@alwayshooin alwayshooin force-pushed the ROX-24086 branch 2 times, most recently from e977a54 to 9ed239d Compare May 30, 2024 21:25
Base automatically changed from ROX-24086 to master May 31, 2024 04:41
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.99%. Comparing base (cfef125) to head (c2947ce).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11164   +/-   ##
=======================================
  Coverage   47.98%   47.99%           
=======================================
  Files        2330     2330           
  Lines      166767   166767           
=======================================
+ Hits        80031    80034    +3     
+ Misses      80381    80379    -2     
+ Partials     6355     6354    -1     
Flag Coverage Δ
go-unit-tests 47.99% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented May 31, 2024

@alwayshooin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-ui-e2e-tests c2947ce link false /test ocp-4-12-ui-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@alwayshooin alwayshooin merged commit 868f8c1 into master May 31, 2024
60 of 61 checks passed
@alwayshooin alwayshooin deleted the ROX-24088 branch May 31, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants