Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add feature flag for VULN_MGMT_NO_CVES_VIEW #11155

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

dvail
Copy link
Contributor

@dvail dvail commented May 17, 2024

Description

A small, mostly UI update, but incremental PRs will break existing Workload CVE views' UX unless gated behind a flag.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

Manual testing that feature flag is returned via the API.

Copy link

openshift-ci bot commented May 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tests/e2e/lib.sh Show resolved Hide resolved
@dvail dvail marked this pull request as ready for review May 17, 2024 12:18
@dvail dvail requested a review from a team as a code owner May 17, 2024 12:18
@rhacs-bot
Copy link
Contributor

rhacs-bot commented May 17, 2024

Images are ready for the commit at e3f510e.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-720-ge3f510ec95.

Copy link

openshift-ci bot commented May 17, 2024

@dvail: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-operator-e2e-tests e3f510e link false /test ocp-4-12-operator-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dvail dvail merged commit f8a4076 into master May 20, 2024
70 of 71 checks passed
@dvail dvail deleted the dv/no-cves-view-ff branch May 20, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants