Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-22051: retry tls dial in test #11153

Merged
merged 2 commits into from
May 22, 2024
Merged

ROX-22051: retry tls dial in test #11153

merged 2 commits into from
May 22, 2024

Conversation

janisz
Copy link
Contributor

@janisz janisz commented May 17, 2024

Description

From time to time we have an error on connecting to central in our non groovy e2e tls test. This PR adds retry mechanism to those calls (only if error is not expected).

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

Here I tell how I validated my change

CI

Reminder for reviewers

In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@rhacs-bot
Copy link
Contributor

rhacs-bot commented May 17, 2024

Images are ready for the commit at d696498.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-698-gd696498d46.

@janisz janisz requested review from gavin-stackrox and a team May 17, 2024 14:37
Copy link
Contributor

@gavin-stackrox gavin-stackrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from minor spelling change required.

tests/endpoints_test.go Outdated Show resolved Hide resolved
tests/endpoints_test.go Outdated Show resolved Hide resolved
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz enabled auto-merge (squash) May 21, 2024 14:32
Copy link

openshift-ci bot commented May 21, 2024

@janisz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-sensor-integration-tests d696498 link false /test gke-sensor-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@janisz janisz disabled auto-merge May 22, 2024 08:42
@janisz janisz merged commit 17b34f7 into master May 22, 2024
57 of 58 checks passed
@janisz janisz deleted the ROX-22051_retry_tls_dial branch May 22, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants