Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-24045: telemetry gatherer to use WithNoDuplicates #11152

Merged
merged 2 commits into from
May 22, 2024

Conversation

0x656b694d
Copy link
Contributor

@0x656b694d 0x656b694d commented May 17, 2024

Refactoring of the phonehome telemetry gatherer framework:

  • Remove the gatherer cache in favor of the generic telemeter cache, enabled with the WithNoDuplicates option.
  • Remove the "Heartbeat" event in favor of the daily, potentially duplicate, "Updated * Identity" event.

Tests:

  • Unit tests

@0x656b694d 0x656b694d changed the title michael/telemetry-withnodups-gatherer ROX-24045: telemetry gatherer to use WithNoDuplicates May 17, 2024
@rhacs-bot
Copy link
Contributor

rhacs-bot commented May 17, 2024

Images are ready for the commit at fb2badf.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-758-gfb2badfc20.

@0x656b694d 0x656b694d force-pushed the michael/ROX-24045-sec-clu-identity-freq branch from 9866b53 to 835bc94 Compare May 17, 2024 14:14
@0x656b694d 0x656b694d force-pushed the michael/telemetry-withnodups-gatherer branch from 4faf927 to ea25777 Compare May 17, 2024 14:39
@0x656b694d 0x656b694d force-pushed the michael/ROX-24045-sec-clu-identity-freq branch from 835bc94 to 161d0ca Compare May 21, 2024 13:39
@0x656b694d 0x656b694d force-pushed the michael/telemetry-withnodups-gatherer branch from ea25777 to 2ba5e7f Compare May 21, 2024 13:39
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 47.96%. Comparing base (1a5476a) to head (fb2badf).
Report is 2 commits behind head on master.

Files Patch % Lines
central/telemetry/centralclient/instance_config.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11152      +/-   ##
==========================================
- Coverage   47.97%   47.96%   -0.01%     
==========================================
  Files        2330     2330              
  Lines      166663   166667       +4     
==========================================
- Hits        79953    79944       -9     
- Misses      80359    80370      +11     
- Partials     6351     6353       +2     
Flag Coverage Δ
go-unit-tests 47.96% <38.46%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0x656b694d 0x656b694d requested a review from a team May 21, 2024 14:44
@0x656b694d 0x656b694d force-pushed the michael/ROX-24045-sec-clu-identity-freq branch from 6d30296 to d4f64b0 Compare May 22, 2024 07:44
@0x656b694d 0x656b694d force-pushed the michael/telemetry-withnodups-gatherer branch from 2ba5e7f to 64ee262 Compare May 22, 2024 07:44
Base automatically changed from michael/ROX-24045-sec-clu-identity-freq to master May 22, 2024 12:20
@0x656b694d 0x656b694d force-pushed the michael/telemetry-withnodups-gatherer branch from 64ee262 to fb2badf Compare May 22, 2024 12:24
@0x656b694d 0x656b694d enabled auto-merge (squash) May 22, 2024 12:24
@0x656b694d 0x656b694d merged commit 64b82ec into master May 22, 2024
57 of 65 checks passed
@0x656b694d 0x656b694d deleted the michael/telemetry-withnodups-gatherer branch May 22, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants