Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-24182: update workload CVE overview header #11144

Merged
merged 1 commit into from
May 22, 2024

Conversation

dvail
Copy link
Contributor

@dvail dvail commented May 16, 2024

Description

Updates the Workload CVE page to have a more descriptive header above the table, and moves the Namespace View and Default filter buttons into this header.

Follow up

The NS view and Default Filter buttons should only be displayed for "Observed" - we need to remove them for Deferred and FP tabs. https://issues.redhat.com/browse/ROX-24318

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

With CVEs:
image

Without CVEs:
image

Feature flag off:
image

Copy link

openshift-ci bot commented May 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dvail dvail changed the base branch from master to dv/ROX-24183-images-without-vulns-queries May 16, 2024 19:24
@dvail dvail force-pushed the dv/ROX-24183-images-without-vulns-queries branch from 419a76a to 7fe6c13 Compare May 16, 2024 19:31
@dvail dvail force-pushed the dv/ROX-24182-update-workload-cve-overview-header branch 2 times, most recently from f91558e to 91db199 Compare May 16, 2024 19:42
@rhacs-bot
Copy link
Contributor

rhacs-bot commented May 16, 2024

Images are ready for the commit at 59d6484.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-767-g59d6484dd1.

@dvail dvail force-pushed the dv/ROX-24183-images-without-vulns-queries branch from 7fe6c13 to 632cce2 Compare May 16, 2024 20:04
@dvail dvail force-pushed the dv/ROX-24182-update-workload-cve-overview-header branch 3 times, most recently from 0d39571 to 387c513 Compare May 17, 2024 15:25
@dvail dvail force-pushed the dv/ROX-24183-images-without-vulns-queries branch 2 times, most recently from 4026c0a to 3a3db72 Compare May 17, 2024 15:37
@dvail dvail force-pushed the dv/ROX-24182-update-workload-cve-overview-header branch from 387c513 to f6dfcb3 Compare May 17, 2024 15:43
@dvail dvail force-pushed the dv/ROX-24183-images-without-vulns-queries branch from 3a3db72 to de750b0 Compare May 17, 2024 15:48
@dvail dvail force-pushed the dv/ROX-24182-update-workload-cve-overview-header branch 2 times, most recently from d161191 to a1d1836 Compare May 17, 2024 17:20
@dvail dvail force-pushed the dv/ROX-24183-images-without-vulns-queries branch from de750b0 to e6ae7b9 Compare May 17, 2024 17:20
@dvail dvail requested a review from alwayshooin May 20, 2024 17:56
@dvail dvail marked this pull request as ready for review May 20, 2024 17:56
@dvail dvail requested a review from a team as a code owner May 20, 2024 17:56
@dvail dvail force-pushed the dv/ROX-24183-images-without-vulns-queries branch from e6ae7b9 to ef3bedd Compare May 22, 2024 14:20
Base automatically changed from dv/ROX-24183-images-without-vulns-queries to master May 22, 2024 16:11
@dvail dvail force-pushed the dv/ROX-24182-update-workload-cve-overview-header branch from a1d1836 to 59d6484 Compare May 22, 2024 16:13
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.97%. Comparing base (bf602fc) to head (59d6484).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11144   +/-   ##
=======================================
  Coverage   47.97%   47.97%           
=======================================
  Files        2330     2330           
  Lines      166667   166667           
=======================================
  Hits        79955    79955           
+ Misses      80362    80361    -1     
- Partials     6350     6351    +1     
Flag Coverage Δ
go-unit-tests 47.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented May 22, 2024

@dvail: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-15-ui-e2e-tests 59d6484 link false /test ocp-4-15-ui-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dvail
Copy link
Contributor Author

dvail commented May 22, 2024

ocp-4-15 failure is an existing Config Management flake

@dvail dvail merged commit 67eaab7 into master May 22, 2024
60 of 61 checks passed
@dvail dvail deleted the dv/ROX-24182-update-workload-cve-overview-header branch May 22, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants