-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-24181: images wo cves dropdown #11142
Conversation
Skipping CI for Draft Pull Request. |
Images are ready for the commit at 0aa4e25. To use with deploy scripts, first |
0f70f15
to
da5210e
Compare
da5210e
to
0236b28
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11142 +/- ##
==========================================
- Coverage 47.89% 47.89% -0.01%
==========================================
Files 2330 2330
Lines 166491 166491
==========================================
- Hits 79748 79747 -1
Misses 80414 80414
- Partials 6329 6330 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0236b28
to
0aa4e25
Compare
@dvail: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Failing test is due to a network error fetching the Cypress binary, and passed before the rebase. |
Description
Adds a dropdown menu to the Workload CVEs "Observed" tab that allows a user to switch between "With CVEs" and images "Without CVEs" views.
This PR only adds the menu and URL parameter, but has no function otherwise.
Checklist
If any of these don't apply, please comment below.
Testing Performed
Default when navigating to Workload CVEs - note the URL parameter.
Changing the dropdown value:
With the feature flag disabled:
Note that the URL parameter still exists, and could potentially be manually edited to be "WITHOUT_CVES". I think the chances of: 1. this functionality not making it to 4.5 and 2. a user doing this intentionally are small enough that we shouldn't worry about flagging the URL params. If we approach the release date and this is looking to be an issue we can reconsider.