Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-24181: images wo cves dropdown #11142

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

dvail
Copy link
Contributor

@dvail dvail commented May 16, 2024

Description

Adds a dropdown menu to the Workload CVEs "Observed" tab that allows a user to switch between "With CVEs" and images "Without CVEs" views.

This PR only adds the menu and URL parameter, but has no function otherwise.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

Default when navigating to Workload CVEs - note the URL parameter.
image

Changing the dropdown value:
image
image

With the feature flag disabled:
image

Note that the URL parameter still exists, and could potentially be manually edited to be "WITHOUT_CVES". I think the chances of: 1. this functionality not making it to 4.5 and 2. a user doing this intentionally are small enough that we shouldn't worry about flagging the URL params. If we approach the release date and this is looking to be an issue we can reconsider.

Copy link

openshift-ci bot commented May 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dvail dvail changed the base branch from master to dv/workload-cve-query-filter-refactor May 16, 2024 19:24
@rhacs-bot
Copy link
Contributor

rhacs-bot commented May 16, 2024

Images are ready for the commit at 0aa4e25.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-755-g0aa4e25650.

Base automatically changed from dv/workload-cve-query-filter-refactor to master May 17, 2024 12:10
@dvail dvail changed the base branch from master to dv/no-cves-view-ff May 17, 2024 14:59
@dvail dvail force-pushed the dv/ROX-24181-images-wo-cves-dropdown branch from 0f70f15 to da5210e Compare May 17, 2024 15:26
@dvail dvail marked this pull request as ready for review May 17, 2024 18:05
@dvail dvail requested a review from a team as a code owner May 17, 2024 18:05
@dvail dvail requested a review from alwayshooin May 17, 2024 18:05
Base automatically changed from dv/no-cves-view-ff to master May 20, 2024 12:01
@dvail dvail force-pushed the dv/ROX-24181-images-wo-cves-dropdown branch from da5210e to 0236b28 Compare May 21, 2024 19:45
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.89%. Comparing base (3e2f098) to head (0236b28).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11142      +/-   ##
==========================================
- Coverage   47.89%   47.89%   -0.01%     
==========================================
  Files        2330     2330              
  Lines      166491   166491              
==========================================
- Hits        79748    79747       -1     
  Misses      80414    80414              
- Partials     6329     6330       +1     
Flag Coverage Δ
go-unit-tests 47.89% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvail dvail force-pushed the dv/ROX-24181-images-wo-cves-dropdown branch from 0236b28 to 0aa4e25 Compare May 22, 2024 12:05
Copy link

openshift-ci bot commented May 22, 2024

@dvail: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-scanner-v4-tests da5210e link false /test ocp-4-12-scanner-v4-tests
ci/prow/ocp-4-15-scanner-v4-tests da5210e link false /test ocp-4-15-scanner-v4-tests
ci/prow/ui-component-tests 0aa4e25 link false /test ui-component-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dvail
Copy link
Contributor Author

dvail commented May 22, 2024

Failing test is due to a network error fetching the Cypress binary, and passed before the rebase.

@dvail dvail merged commit 7bb035b into master May 22, 2024
56 of 59 checks passed
@dvail dvail deleted the dv/ROX-24181-images-wo-cves-dropdown branch May 22, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants