Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-24100: Profile clusters table pagination #11140

Merged
merged 1 commit into from
May 20, 2024

Conversation

bradr5
Copy link
Contributor

@bradr5 bradr5 commented May 16, 2024

Description

Adds pagination to the Compliance V2 Profile Clusters table

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

Screenshot 2024-05-16 at 12 17 09 PM

@bradr5 bradr5 requested a review from a team as a code owner May 16, 2024 17:19
@rhacs-bot
Copy link
Contributor

rhacs-bot commented May 16, 2024

Images are ready for the commit at 7d99d25.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-712-g7d99d25178.

Copy link
Contributor

@pedrottimark pedrottimark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good size chunk. I compared to corresponding changes for checks in #11064

Base automatically changed from ROX-23692_add_profile_clusters_results to master May 17, 2024 07:17
@bradr5 bradr5 force-pushed the bradr/ROX-24100_profile_clusters_pagination branch from 05e48e0 to 7d99d25 Compare May 17, 2024 07:23
Copy link
Contributor

@sachaudh sachaudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, LGTM

@bradr5 bradr5 merged commit c35b443 into master May 20, 2024
59 checks passed
@bradr5 bradr5 deleted the bradr/ROX-24100_profile_clusters_pagination branch May 20, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants