Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-23220: rocksdb changelog #11134

Merged
merged 3 commits into from
May 20, 2024
Merged

ROX-23220: rocksdb changelog #11134

merged 3 commits into from
May 20, 2024

Conversation

dashrews78
Copy link
Contributor

Description

Updates for rmoving RocksDB

Checklist

- [ ] Investigated and inspected CI test results
- [ ] Unit test and regression tests added
- [ ] Evaluated and added CHANGELOG entry if required
- [ ] Determined and documented upgrade steps
- [ ] Documented user facing changes (create PR based on [openshift/openshift-docs](https://github.com/openshift/openshift-docs) and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

Here I tell how I validated my change

TODO(replace-me)
Use this space to explain how you validated that your change functions exactly how you expect it.
Feel free to attach JSON snippets, curl commands, screenshots, etc. Apply a simple benchmark: would the information you
provided convince any reviewer or any external reader that you did enough to validate your change.

It is acceptable to assume trust and keep this section light, e.g. as a bullet-point list.

It is acceptable to skip testing in cases when CI is sufficient, or it's a markdown or code comment change only.
It is also acceptable to skip testing for changes that are too taxing to test before merging. In such case you are
responsible for the change after it gets merged which includes reverting, fixing, etc. Make sure you validate the change
ASAP after it gets merged or explain in PR when the validation will be performed.
Explain here why you skipped testing in case you did so.

Have you created automated tests for your change? Explain here which validation activities you did manually and why so.

Reminder for reviewers

In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

@dashrews78 dashrews78 requested a review from a team May 16, 2024 13:53
@rhacs-bot
Copy link
Contributor

rhacs-bot commented May 16, 2024

Images are ready for the commit at 9e59974.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-706-g9e59974382.

CHANGELOG.md Outdated Show resolved Hide resolved
@dashrews78 dashrews78 requested a review from c-du May 17, 2024 16:58
Copy link

openshift-ci bot commented May 17, 2024

@dashrews78: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-qa-e2e-tests 9e59974 link false /test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dashrews78 dashrews78 merged commit fd168d8 into master May 20, 2024
57 of 58 checks passed
@dashrews78 dashrews78 deleted the dashrews/rocksdb-changelog branch May 20, 2024 18:16
dcaravel added a commit that referenced this pull request May 21, 2024
updates for rocksdb removal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants