fix dynamic insert-css usage #12
Merged
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses forked version of `static-module`: browserify/static-module#22 fixes choojs/bankai#109
Current coverage is 97.36% (diff: 100%)@@ master #12 diff @@
==========================================
Files 1 1
Lines 38 38
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 37 37
Misses 1 1
Partials 0 0
|
yoshuawuyts
previously requested changes
Dec 16, 2016
|
Just checking in on this one. Seems like |
|
@jondashkyle I kinda feel that if this patch is needed too complex things are being done. Also no movement on the other patch, so think this is not going to land anytime soon (unless more work is done, but it's been a bit stale lately unforch) |
goto-bus-stop
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses forked version of
static-module: browserify/static-module#22fixes choojs/bankai#109