-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to RefResolver
#1215
Conversation
68562c8
to
ea904cf
Compare
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
…mas instead
Ok! I now understand jsonschema a lot better than I did. As part of that I realized that the |
Yeah, in retrospect # in pystac/validation/local_validator.py
warnings.warn("This module is deprecated and will be removed in v2")
from ._local_validator import *
__all__ = ["the", "things", "we", "need", "to", "export"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me ... I think the only outstanding question is #1215 (comment).
Hmm the functionality in the old vs new are pretty different. Maybe I should just leave the old |
Ok see what you think about this approach to deprecation. Note that it probably won't have quite as good coverage as main because the deprecated class is untested. I can add some new tests if that is too gross. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small nit then we should be good, thanks!
Nah, tests just for coverage sake on deprecated things is a waste of time IMO :-). LGTM. |
Related Issue(s):
RefResolver
#1186Description:
I am working though the recommendations on https://python-jsonschema.readthedocs.io/en/latest/referencing/ these are the steps as I understand them:
RefResolver
withRegistry
PR Checklist:
pre-commit
hooks pass locallyscripts/test
)