fix: properly calculate content-length for cfn custom resource respon…

…ses (#3584)
sst · Jan 10, 2024 · 5201a37 · 5201a37
1 parent d45f36c
commit 5201a37
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 5 deletions.
diff --git a/.changeset/odd-windows-lick.md b/.changeset/odd-windows-lick.md
@@ -0,0 +1,5 @@
+---
+"sst": patch
+---
+
+Properly calculate content-length for cfn custom resource responses
diff --git a/packages/sst/support/certificate-requestor/index.mjs b/packages/sst/support/certificate-requestor/index.mjs
@@ -54,7 +54,7 @@ let report = function (
       method: "PUT",
       headers: {
         "Content-Type": "",
-        "Content-Length": responseBody.length,
+        "Content-Length": Buffer.byteLength(responseBody.length, "utf-8"),
       },
     };
 

diff --git a/packages/sst/support/custom-resources/cfn-response.ts b/packages/sst/support/custom-resources/cfn-response.ts
@@ -53,7 +53,7 @@ export async function submitResponse(
       method: "PUT",
       headers: {
         "content-type": "",
-        "content-length": responseBody.length,
+        "content-length": Buffer.byteLength(responseBody.length, "utf-8"),
       },
     },
     responseBody

diff --git a/packages/sst/support/edge-function/cfn-response.ts b/packages/sst/support/edge-function/cfn-response.ts
@@ -51,7 +51,7 @@ export async function submitResponse(
       method: "PUT",
       headers: {
         "content-type": "",
-        "content-length": responseBody.length,
+        "content-length": Buffer.byteLength(responseBody.length, "utf-8"),
       },
     },
     responseBody

diff --git a/packages/sst/support/script-function/cfn-response.ts b/packages/sst/support/script-function/cfn-response.ts
@@ -53,7 +53,7 @@ export async function submitResponse(
       method: "PUT",
       headers: {
         "content-type": "",
-        "content-length": responseBody.length,
+        "content-length": Buffer.byteLength(responseBody.length, "utf-8"),
       },
     },
     responseBody

diff --git a/packages/sst/support/sls-nextjs-site-function-code-replacer/lambda-code-updater.py b/packages/sst/support/sls-nextjs-site-function-code-replacer/lambda-code-updater.py
@@ -144,7 +144,7 @@ def cfn_send(event, context, responseStatus, responseData={}, physicalResourceId
 
     headers = {
         'content-type' : '',
-        'content-length' : str(len(body))
+        'content-length' : str(len(body.encode('utf-8')))
     }
 
     try: