Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overwrite nick color #375

Merged
merged 3 commits into from May 14, 2024
Merged

feat: overwrite nick color #375

merged 3 commits into from May 14, 2024

Conversation

casperstorm
Copy link
Member

Ability to overwrite nickname colors by providing a hex string.
Note that I didn't add any breaking changes since we are still able to deserde from a string, instead of a map:

The new format looks like

[buffer.nickname.color]
kind = "unique"
hex = "#ff0000" # optional

But we still correctly parse

[buffer.nickname]
color = "unique"

@casperstorm casperstorm requested a review from tarkah May 8, 2024 20:43
Copy link
Member

@tarkah tarkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I made one change to simplify the backwards compatible deserialization implementation. Can you please confirm it still works before merging?

@casperstorm casperstorm merged commit e48ad4b into main May 14, 2024
1 check passed
@casperstorm casperstorm deleted the feat/overwrite-nick-color branch May 14, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants