Add support for Windows binary meta information and fix WiX installer… #371
Conversation
wix/main.wxs
Outdated
| Version='0.0.{{ VERSION }}'> | ||
| Version='{{ VERSION }}.0.0'> |
There was a problem hiding this comment.
I am not the big Windows user, but noticed that I have apps with different version notations.
Surely there must be a way for us to do yyyy.count like we do everywhere else? I just recall adding 0.0.{{ VERSION }} because otherwise WiX would fail to compile 🤔
There was a problem hiding this comment.
Yea, well it is an Windows Installer SDK limitation (which is, IMHO, bad). That means that the Windows version will be always differ from the version in the VERSION file, as the major version must be less than 256. :-(
I will change the PR.
There was a problem hiding this comment.
To be more precise it seems a WiX 3 limitation. The Windows Installer SDK itself defines version as documented here. I made a brief attempt with WiX 5 and it seems that there is a warning if the version is "2004.7" and no error. Is it an option to rewrite the WiX description and migrate to WiX 5? I could make this.
There was a problem hiding this comment.
To be more precise it seems a WiX 3 limitation. The Windows Installer SDK itself defines version as documented here. I made a brief attempt with WiX 5 and it seems that there is a warning if the version is "2004.7" and no error. Is it an option to rewrite the WiX description and migrate to WiX 5? I could make this.
You are VERY welcome to do that!
| @@ -4,8 +4,10 @@ | |||
| #!/bin/bash | |||
| EXE_NAME="halloy.exe" | |||
| TARGET="x86_64-pc-windows-msvc" | |||
| VERSION=$(cat VERSION).0 | |||
There was a problem hiding this comment.
We should keep Product version and File version equal imho.
And preferably both stick to our normal schematics.
With above they turn into:
File version: Y.X.0.0
Product version: Y.X.0
This reverts commit 60c2194.
This PR add support for getting the Windows binary meta information in line with the release version and some other information. Also it updates the WiX installer description to have to correct release version also.
To achieve this i added two build dependencies:
Tell me what you think.