Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added packaging profile for release builds #367

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rawhuul
Copy link

@rawhuul rawhuul commented May 5, 2024

As discussed in issue #361

Copy link
Member

@casperstorm casperstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarkah any feedback?

Copy link
Member

@tarkah tarkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should leverage this profile in our release scripts that produce the final binary.

Comment on lines +57 to +64
opt-level = 3
debug = false
lto = "fat"
strip = "debuginfo"
panic = 'unwind'
incremental = false
codegen-units = 1
rpath = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to redefine the items that are identical to the release profile since we use inherits below. Let's remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants