Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed DefaultFlatParamObject to work with annotated parameters. Fixes… #2183

Merged
merged 1 commit into from Mar 30, 2023

Conversation

uc4w6c
Copy link
Collaborator

@uc4w6c uc4w6c commented Mar 30, 2023

fix #2181

Since there is no test code in the repository from before, I don't know why it is doing annotation checks.
However, since the target parameter can be determined by AbstractRequestService.isRequestTypeToIgnore, I would like to remove the annotation retention confirmation process.

Related PR: https://github.com/springdoc/springdoc-openapi/pull/1805/files

@Charles7c
Copy link

I am looking forward to updating.

@bnasslahsen
Copy link
Contributor

@uc4w6c,

Thank you for your contribution to the project!

@bnasslahsen bnasslahsen merged commit 4d06552 into springdoc:master Mar 30, 2023
@NaccOll
Copy link
Contributor

NaccOll commented Jun 27, 2023

@Charles7c @uc4w6c
DefaultFlatParamObject is what I added to reduce the usage of ParameterObject. Stopping automatic flattening of objects when annotations are found is itself an expected behavior, because when I annotate an object, I don't want him to be flattened (like @requestbody, @RequestPart). If you want to add annotations to keep things flat, you should add configuration to ignore specified annotations instead of removing this code directly. Because of this pr, there are problems with all methods using @requestbody and @RequestPart at present, and the document cannot be displayed correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default-flat-param-object does not take effect
4 participants