Dropped Nimbus Error Message gh 13730 #14185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Caguilar92 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@Caguilar92 Thank you for signing the Contributor License Agreement! |
jzheaux
requested changes
Nov 29, 2023
There was a problem hiding this comment.
Thanks for the PR, @Caguilar92! In addition to my inline feedback, will you also please add a test that demonstrates the changed behavior?
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java
Outdated
Show resolved
Hide resolved
jzheaux
added
status: duplicate
|
@Caguilar92, thanks for the updates. In preparation for merging, will you please ensure that there is only one commit in your PR? Also, I believe there is one remaining feedback item about a stray commit in the PR. Let me know if you need help correcting that. |
Caguilar92
force-pushed
the
gh-13730
branch
3 times, most recently
from
c2ed083
to
e24e3a4
Compare
jzheaux
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught ParseExcepetion, dropped nimbus error message, and replace with Malformed header.