Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix caching error state in ReactiveRemoteJWKSource #13976

Closed
wants to merge 1 commit into from
Closed

Fix caching error state in ReactiveRemoteJWKSource #13976

wants to merge 1 commit into from

Conversation

dongelci
Copy link
Contributor

@dongelci dongelci commented Oct 9, 2023

Closes gh-13757

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 9, 2023
@sjohnr sjohnr self-assigned this Oct 11, 2023
@sjohnr
Copy link
Member

sjohnr commented Oct 12, 2023

Thanks for the PR @dongelci! I have looked through the code and it generally looks good, though I will add a polish commit to update the way the cachedJwkSetUrl is used in order to keep final on the field containing the URL. While working on that, I found that there are some conflicts back-porting this branch to 5.8.x, as there was a new feature introduced in the 6.1 release and some refactoring changes in 6.2 release (main). For that reason, I may have to work on this next week and it probably won't make it into this month's release.

@sjohnr sjohnr added type: bug A general bug in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 12, 2023
@dongelci
Copy link
Contributor Author

@sjohnr thanks. If I can support somehow, let me know please

@sjohnr sjohnr modified the milestones: 5.8.x, 5.8.9 Oct 19, 2023
sjohnr added a commit that referenced this pull request Oct 19, 2023
@sjohnr
Polish gh-13976
5161712 
Closes gh-13757
@sjohnr
Copy link
Member

sjohnr commented Oct 19, 2023

@dongelci thanks for your contribution! This is now merged into 5.8.x via a6b872d with a polish commit 5161712.

@sjohnr sjohnr closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sjohnr sjohnr

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Projects
Spring Security Team
Archived in project
Milestone
5.8.9
Development

Successfully merging this pull request may close these issues.

ReactiveRemoteJWKSource caches invalid response status into jwkSetURL
3 participants
@dongelci @sjohnr @spring-projects-issues