SAML 2.0 HTTP Redirect Binding query params may appear in any order #12963
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukaszmigdalek Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@lukaszmigdalek Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
type: bug
|
Thanks, @lukaszmigdalek, for the PR. This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to my latest comment:
#12346 (comment)
SAML 2.0 HTTP Redirect Binding specification says that query params may appear in any order.
"Note that when verifying signatures, the order of the query string parameters on the resulting URL to be
verified is not prescribed by this binding. The parameters may appear in any order. Before verifying a
signature, if any, the relying party MUST ensure that the parameter values to be verified are ordered as
required by the signing rules above."
Added support for a different order of query params based on the previous implementation:
88f9529
gh-12346
#12346