Add test to SimpleUrlAuthenticationSuccessHandlerTests #12740
Merged
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
twosom
force-pushed
the
add-post-process-validate-on-simple-url-authentication-fileter
branch
from
d1ff26d to
1386216
Compare
|
Thanks for the PR, @twosom! So that we can confirm that this feature continues to work on all branches, will you please rebase this off of |
jzheaux
added
in: web
twosom
force-pushed
the
add-post-process-validate-on-simple-url-authentication-fileter
branch
from
1386216 to
ebdd16e
Compare
twosom
force-pushed
the
add-post-process-validate-on-simple-url-authentication-fileter
branch
from
ebdd16e to
702e370
Compare
|
Thanks, @twosom! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
onAuthenticationSuccessmethod of theSimpleUrlAuthenticationSuccessHandler, theclearAuthenticationAttributesmethod is used to removeAuthenticationExceptionobjects that may be left in the session.However, since there was no verification of whether this logic was working properly in test cases of
SimpleUrlAuthenticationSuccessHandler, I added tests to verify it.