The TRUSTED_PACKAGES field in the DefaultJackson2JavaTypeMapper has also been improved to have an ImmutableList type. #2875
+2
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avaTypeMapper class to a List.of method that returns an ImmutableList.
ch4570
changed the title
ch4570
changed the title
artembilan
requested changes
Nov 2, 2023
There was a problem hiding this comment.
> Task :spring-kafka:checkstyleMain FAILED
Error: eckstyle] [ERROR] /home/runner/work/spring-kafka/spring-kafka/spring-kafka/src/main/java/org/springframework/kafka/support/mapping/DefaultJackson2JavaTypeMapper.java:19:8: Unused import - java.util.Arrays. [UnusedImports]
|
@ch4570 , thank you for contribution; looking forward for more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
The Arrays.asList method creates a List based on variable arguments, which can lead to heap pollution, and TRUST_PACKAGES is an immutable field, so it has been improved to utilize Immutable List.
Improved to call the empty method to clarify the intent, rather than directly comparing integers to see if the size of a Set is zero.