Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference to ApplicationContext#getAutowireCapableBeanFactory in reference documentation #34400

Conversation

canattofilipe
Copy link

@canattofilipe canattofilipe commented Feb 10, 2025

Adjust doc to start using getAutowireCapableBeanFactory ref, since getBeanFactory is not available on the ApplicationContext interface.

@canattofilipe canattofilipe changed the title Fix: Adjust Bean Overview Doc to Start using getAutowireCapableBeanFa… Fix: Adjust Bean Overview Doc to Start using getAutowireCapableBeanFactory Feb 10, 2025
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 10, 2025
@bclozel
Copy link
Member

bclozel commented Feb 10, 2025

@canattofilipe you will need to sign your commit for the DCO.

You can use "git amend -s" and force push. See https://spring.io/blog/2025/01/06/hello-dco-goodbye-cla-simplifying-contributions-to-spring

…ctory Instead of getBeanFactory

Signed-off-by: canattofilipe <canattofilipe@gmail.com>
@canattofilipe canattofilipe force-pushed the update-beans-doc-overview branch from d854b20 to 4c08b3f Compare February 10, 2025 21:51
@canattofilipe
Copy link
Author

canattofilipe commented Feb 10, 2025

@bclozel Done, ty!

@snicoll snicoll added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 11, 2025
@snicoll snicoll added this to the 6.2.3 milestone Feb 11, 2025
@snicoll snicoll self-assigned this Feb 11, 2025
@snicoll snicoll changed the title Fix: Adjust Bean Overview Doc to Start using getAutowireCapableBeanFactory Fix reference to ApplicationContext#getAutowireCapableBeanFactory in reference documentation Feb 11, 2025
snicoll pushed a commit that referenced this pull request Feb 11, 2025
See gh-34400

Signed-off-by: canattofilipe <canattofilipe@gmail.com>
@snicoll snicoll closed this in bd1c7b3 Feb 11, 2025
@snicoll
Copy link
Member

snicoll commented Feb 11, 2025

@canattofilipe, thanks for making your first contribution to Spring Framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants