Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor update in WebSocket STOMP reference documentation #34353

Closed
wants to merge 1 commit into from
Closed

Minor update in WebSocket STOMP reference documentation #34353

wants to merge 1 commit into from
+1 −1

Conversation

pirocraft
Copy link
Contributor

No description provided.

@pirocraft @prossato
Fix typo in websocket STOMP documentation
Loading
Loading status checks…
2e89c18 
Signed-off-by: Pierre Rossato <pierre.rossato@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 1, 2025
@rstoyanchev rstoyanchev added in: messaging Issues in messaging modules (jms, messaging) in: web Issues in web modules (web, webmvc, webflux, websocket) labels Feb 3, 2025
rstoyanchev
rstoyanchev reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, but the way it is phrased currently is as it is intended.

Receiving does not need ordering. It's the subsequent publication (to the clientOutboutChannel) that needs to be orderded.

@rstoyanchev rstoyanchev closed this Feb 3, 2025
@rstoyanchev rstoyanchev added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 3, 2025
@pirocraft
Copy link
Contributor Author

Ok, thanks for your answer and your time!
You mentioned the clientOutboutChannel but it is the clientInboundChannel in this case, I presume.
I think that the strange symmetry between the two channels disturbed me.

Anyway it is clearer to me reading the javadoc of StompEndpointRegistry.setPreserveReceiveOrder(..)

By default messages sent to the "clientInboundChannel" may be handled in parallel [...]
When this flag is set to true messages within the same session will be sent to the "clientInboundChannel" one at a time in order to preserve the order in which they were received.

@rstoyanchev
Copy link
Contributor

You're right, it's about inbound messages in which case the suggestion makes more more sense. Apologies for missing that.

@rstoyanchev rstoyanchev reopened this Feb 3, 2025
@rstoyanchev rstoyanchev self-assigned this Feb 3, 2025
@rstoyanchev rstoyanchev added type: documentation A documentation task and removed status: declined A suggestion or change that we don't feel we should currently apply labels Feb 3, 2025
@rstoyanchev rstoyanchev added this to the 6.2.3 milestone Feb 3, 2025
@rstoyanchev rstoyanchev added type: task A general task and removed type: documentation A documentation task labels Feb 3, 2025
@rstoyanchev rstoyanchev changed the title Fix typo in websocket STOMP documentation Minor update in WebSocket STOMP reference documentation Feb 3, 2025
@snicoll snicoll added type: documentation A documentation task and removed type: task A general task labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstoyanchev rstoyanchev

Assignees

@rstoyanchev rstoyanchev

Labels
in: messaging Issues in messaging modules (jms, messaging) in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Projects
None yet
Milestone
6.2.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pirocraft @rstoyanchev @snicoll @spring-projects-issues