Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diagnostics when a Bean Override cannot be selected by type #34006

Closed
wants to merge 1 commit into from
Closed

Improve diagnostics when a Bean Override cannot be selected by type #34006

wants to merge 1 commit into from
+21 −13

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Dec 3, 2024

Close GH-34004

@quaff quaff mentioned this pull request Dec 3, 2024
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 3, 2024
@rstoyanchev rstoyanchev added the in: core Issues in core modules (aop, beans, core, context, expression) label Feb 3, 2025
@snicoll snicoll added in: test Issues in the test module and removed in: core Issues in core modules (aop, beans, core, context, expression) labels Feb 4, 2025
@sbrannen
Copy link
Member

sbrannen commented Feb 8, 2025

Thanks for the PR, @quaff! 👍

Would you be willing to rebase on 6.2.x, resolve any conflicts, and force push the result?

@sbrannen sbrannen added status: waiting-for-feedback We need additional information before we can continue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 8, 2025
@sbrannen sbrannen mentioned this pull request Feb 8, 2025
Closed
@sbrannen sbrannen added this to the 6.2.3 milestone Feb 8, 2025
@sbrannen sbrannen self-assigned this Feb 8, 2025
@quaff quaff changed the base branch from main to 6.2.x February 10, 2025 02:36
@quaff quaff marked this pull request as draft February 10, 2025 02:44
@quaff
Improve diagnostics when a Bean Override cannot be selected by type

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
e89dfbe 
Close spring-projectsGH-34004

Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
@quaff quaff marked this pull request as ready for review February 10, 2025 02:58
@quaff
Copy link
Contributor Author

quaff commented Feb 10, 2025

Thanks for the PR, @quaff! 👍

Would you be willing to rebase on 6.2.x, resolve any conflicts, and force push the result?

@sbrannen Done.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 10, 2025
sbrannen added a commit to sbrannen/spring-framework that referenced this pull request Feb 10, 2025
@sbrannen
Revise contribution
Loading
Loading status checks…
d59991f 
See spring-projectsgh-34006
@sbrannen sbrannen closed this in cf46f39 Feb 10, 2025
@sbrannen
Copy link
Member

This has been merged into 6.2.x and main in cf46f39 and revised in d59991f.

Thanks

@sbrannen sbrannen removed the status: feedback-provided Feedback has been provided label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.3
Development

Successfully merging this pull request may close these issues.

Improve diagnostics when a Bean Override cannot be selected by type
5 participants
@quaff @sbrannen @rstoyanchev @snicoll @spring-projects-issues