Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in RestClient documentation #33350

Conversation

crusherd
Copy link
Contributor

@crusherd crusherd commented Aug 8, 2024

When copy & pasting the error handling example with the lambda expression, Eclipse complains that a ";" is missing in the throw clause. This update adds the missing ";"

snicoll and others added 2 commits July 11, 2024 09:40

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@pivotal-cla
Copy link

@crusherd Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@crusherd Thank you for signing the Contributor License Agreement!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 8, 2024
@sbrannen sbrannen self-assigned this Aug 8, 2024
@sbrannen sbrannen added type: documentation A documentation task in: web Issues in web modules (web, webmvc, webflux, websocket) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 8, 2024
@sbrannen sbrannen changed the title Rest client documentation - potential java compile error with copy & paste Fix syntax error in RestClient documentation Aug 8, 2024
@sbrannen sbrannen added this to the 6.1.12 milestone Aug 8, 2024
@sbrannen sbrannen closed this in a31945f Aug 8, 2024
@sbrannen
Copy link
Member

sbrannen commented Aug 8, 2024

Thanks for the PR, @crusherd.

This has been merged into 6.1.x and main.

For your next PR, please make sure you rebase on main before submitting the PR.

For example, this PR should have contained a single commit (e45b405) on top of main instead of 3 commits.

@crusherd
Copy link
Contributor Author

crusherd commented Aug 8, 2024

Thank you, I will consider this.
The starting point was the "Edit this page" functionality of the webpage itself. From there I created a fork and the PR. On PR creation I got the information, that there is a merge conflict which I resolved in the web browser.

@crusherd crusherd deleted the patch/rest-client-doc-java-compile-error branch August 8, 2024 14:25
@sbrannen
Copy link
Member

sbrannen commented Aug 8, 2024

The starting point was the "Edit this page" functionality of the webpage itself. From there I created a fork and the PR. On PR creation I got the information, that there is a merge conflict which I resolved in the web browser.

Ah, OK.

I haven't tried that workflow personally, so I'm unfamiliar with it.

Perhaps there's a way to rebase on main after the fact via the web browser. If not, you can rebase on main with a git client and then force push. And otherwise we'll sort it out when merging. For this particular case, I effectively cherry-picked that single commit onto 6.1.x which sorted out the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants