Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize phrasing in URI Encoding section #33166

Closed
wants to merge 1 commit into from

Conversation

hunhee98
Copy link
Contributor

@hunhee98 hunhee98 commented Jul 8, 2024

This is a documentation-only change and does not impact any functionality of the framework.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@pivotal-cla
Copy link

@hunhee98 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@hunhee98 Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 8, 2024
@snicoll snicoll changed the title Fix typ in web-uris.adoc Fix typo in URI Encoding section Jul 8, 2024
@snicoll snicoll added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 8, 2024
@snicoll snicoll self-assigned this Jul 8, 2024
@snicoll snicoll added this to the 6.1.11 milestone Jul 8, 2024
@snicoll snicoll changed the title Fix typo in URI Encoding section Harmonize phrasing in URI Encoding section Jul 8, 2024
snicoll pushed a commit that referenced this pull request Jul 8, 2024
snicoll added a commit that referenced this pull request Jul 8, 2024
@snicoll snicoll closed this in 7e7f55c Jul 8, 2024
@snicoll
Copy link
Member

snicoll commented Jul 8, 2024

@hunhee98 thanks. I am not a native speaker but I think "historic reasons" is valid. However, "historical reasons" being used in the vast majority of the code base, it's still worth harmonizing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants