Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultErrorResponseBuilder does not implement headers(Consumer) #33156

Conversation

TAKETODAY
Copy link
Contributor

@Override
public ErrorResponse.Builder header(String headerName, String... headerValues) {
this.headers = (this.headers != null ? this.headers : new HttpHeaders());
for (String headerValue : headerValues) {
this.headers.add(headerName, headerValue);
}
return this;
}
@Override
public ErrorResponse.Builder headers(Consumer<HttpHeaders> headersConsumer) {
return this;
}

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 7, 2024
@snicoll snicoll changed the title Add missing DefaultErrorResponseBuilder#headers(Consumer) implementation DefaultErrorResponseBuilder does not implement #headers(Consumer) Jul 8, 2024
@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 8, 2024
@snicoll snicoll added this to the 6.1.11 milestone Jul 8, 2024
@snicoll snicoll added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Jul 8, 2024
@snicoll snicoll changed the title DefaultErrorResponseBuilder does not implement #headers(Consumer) DefaultErrorResponseBuilder does not implement headers(Consumer) Jul 8, 2024
@snicoll snicoll self-assigned this Jul 8, 2024
@snicoll snicoll closed this in e06115c Jul 8, 2024
@snicoll
Copy link
Member

snicoll commented Jul 8, 2024

@TAKETODAY thanks very much. I've polished your contribution and added a test.

@TAKETODAY TAKETODAY deleted the fix-ErrorResponseBuilder-headers-consumer branch July 8, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants