Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support canEncode() for JAXBElement in Jaxb2XmlEncoder #32977

Closed
wants to merge 1 commit into from
Closed

Support canEncode() for JAXBElement in Jaxb2XmlEncoder #32977

wants to merge 1 commit into from
+4 −1

Conversation

deblockt
Copy link
Contributor

@deblockt deblockt commented Jun 7, 2024 •
edited by sbrannen
Loading

Overview

This PR provides the ability to serialize a JAXBElement using the Jaxb2XmlEncoder by updating canEncode() accordingly.

Related Issues

@deblockt
fix: JAXBElement serialization on webclient
Loading
Loading status checks…
1402416 
close gh-32972
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 7, 2024
@sbrannen sbrannen added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Jun 7, 2024
@sbrannen sbrannen mentioned this pull request Jun 7, 2024
Closed
@sbrannen sbrannen changed the title fix: JAXBElement serialization on webclient Support canEncode() for JAXBElement in Jaxb2XmlEncoder Jun 7, 2024
@sbrannen sbrannen self-assigned this Jun 7, 2024
@sbrannen sbrannen added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 7, 2024
@sbrannen sbrannen added this to the 6.1.9 milestone Jun 7, 2024
@sbrannen sbrannen closed this in 47a5ebf Jun 7, 2024
@sbrannen
Copy link
Member

sbrannen commented Jun 7, 2024

Congratulations on submitting your first PR for the Spring Framework! 👍

This has been merged into 6.1.x and main.

Thanks

@olbinski olbinski mentioned this pull request Jul 22, 2024
Closed
@olbinski
Copy link
Contributor

Hello @sbrannen, @deblockt. This PR contains bug. isAssignableFrom should be done in opposite way. Check: #33258

@deblockt deblockt mentioned this pull request Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Milestone
6.1.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deblockt @sbrannen @olbinski @spring-projects-issues