Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove link to unrelated method in javadoc of AnnotatedBeanDefinitionReader #32560

Closed
wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Apr 1, 2024

It should link doRegisterBean(Class<T> beanClass, String name, Class<? extends Annotation>[] qualifiers, Supplier<T> supplier, BeanDefinitionCustomizer[] customizers) instead of registerBean(Class, String, Class...) but it is private, to make things more simple I'd like to remove it instead of linking all variants of registerBean().

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 1, 2024
It should link `doRegisterBean(Class<T> beanClass, String name, Class<? extends Annotation>[] qualifiers, Supplier<T> supplier, BeanDefinitionCustomizer[] customizers)` instead of `registerBean(Class, String, Class...)` but it is private, to make things more simple I'd like to remove it instead of linking all variants of `registerBean()`.
@snicoll snicoll changed the title Polishing javadoc of AnnotatedBeanDefinitionReader Remove link to private method in javadoc of AnnotatedBeanDefinitionReader Apr 1, 2024
@snicoll snicoll added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 1, 2024
@snicoll snicoll self-assigned this Apr 1, 2024
@snicoll snicoll added this to the 6.1.6 milestone Apr 1, 2024
@snicoll snicoll changed the title Remove link to private method in javadoc of AnnotatedBeanDefinitionReader Remove link to unrelated method in javadoc of AnnotatedBeanDefinitionReader Apr 1, 2024
snicoll pushed a commit that referenced this pull request Apr 1, 2024
@snicoll snicoll closed this in 1fb99e4 Apr 1, 2024
@snicoll
Copy link
Member

snicoll commented Apr 1, 2024

Yeah, I'd rather remove the link altogether. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants