Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default strategy for ProblemDetail error codes wrongly document how "detail" is supported #32446

Closed
wants to merge 1 commit into from

Conversation

LinorDolev
Copy link
Contributor

@LinorDolev LinorDolev commented Mar 14, 2024

Doc fix for #32415
Removed 'details' attribute from documentation as it is not being used in implementation at all.

…ails' attribute from docs

Signed-off-by: Linor Dolev <linordolev@gmail.com>
@pivotal-cla
Copy link

@LinorDolev Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@LinorDolev Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 14, 2024
@snicoll snicoll changed the title DOCS/MODULES/ROOT/PAGES/WEB/WEBMVC: removed unused problemDetail 'details' attribute from docs Default strategy for ProblemDetail error codes wrongly document detail as being supported Mar 15, 2024
@snicoll snicoll added type: documentation A documentation task in: web Issues in web modules (web, webmvc, webflux, websocket) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 15, 2024
@snicoll snicoll self-assigned this Mar 15, 2024
@snicoll snicoll added this to the 6.1.6 milestone Mar 15, 2024
@snicoll snicoll changed the title Default strategy for ProblemDetail error codes wrongly document detail as being supported Default strategy for ProblemDetail error codes wrongly document how "detail" is supported Mar 15, 2024
@snicoll snicoll closed this in 68a3993 Mar 15, 2024
@snicoll
Copy link
Member

snicoll commented Mar 15, 2024

@LinorDolev thank you for your first contribution. For the record, while "detail" is not supported the way it was documented, there is a strategy for it. I've polished the change to make that more explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants