Extract recurring asciidoc links to attributes #31619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extract spring-related links and recurring external links into asciidoctor attributes to be used by the Antora toolchain. It notably homogenizes links to: - IETF RFCs - Java Community Process JSRs - the Java API Documentation (on the Java 17 version) - Kotlin documentations (on the Kotlinlang.org version) - the Spring Boot reference guide (on the `html` version) This commit also reworks most link attributes to follow a Project-Category-Misc syntax. For example, spring-boot-docs rather than docs-spring-boot. Closes spring-projectsgh-26864
bclozel
approved these changes
Nov 17, 2023
|
Looks good to me as well! Let's do this for 6.1.1 right away. |
sbrannen
requested changes
Nov 21, 2023
sbrannen
reviewed
Nov 21, 2023
framework-docs/modules/ROOT/pages/integration/cache/annotations.adoc
Outdated
Show resolved
Hide resolved
|
the only thing in the deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extracts Spring-related links and recurring external links into asciidoctor attributes to be used by the Antora toolchain.
It notably homogenizes links to:
htmlversion)This commit also reworks most link attributes to follow a Project-Category-Misc syntax. For example,
spring-boot-docsrather thandocs-spring-boot.Closes gh-26864