New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a method in MockHttpServletRequestBuilder
to set remote address
#30497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR looks pretty good.
I've only requested a few minor changes.
...st/java/org/springframework/test/web/servlet/request/MockHttpServletRequestBuilderTests.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/test/web/servlet/request/MockHttpServletRequestBuilder.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/test/web/servlet/request/MockHttpServletRequestBuilder.java
Outdated
Show resolved
Hide resolved
...st/java/org/springframework/test/web/servlet/request/MockHttpServletRequestBuilderTests.java
Outdated
Show resolved
Hide resolved
MockHttpServletRequestBuilder
to set remote address
Co-authored-by: Sam Brannen <sam@sambrannen.com>
Congratulations on submitting your first PR for the Spring Framework! 👍 This has been merged into Thanks |
Thank you, @sbrannen! Could we backport this to 5.x? Spring Boot 2.x still relies on 5.x. |
Reopening to introduce in |
Co-authored-by: Sam Brannen <sam@sambrannen.com> Closes spring-projectsgh-30497
Introduce a method in
MockHttpServletRequestBuilder
to set the remote server address.This PR was discussed in gh-30484.