Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SameSite cookie attribute in MockMvcHttpConnector #30264

Closed
wants to merge 1 commit into from
Closed

Support SameSite cookie attribute in MockMvcHttpConnector #30264

wants to merge 1 commit into from

Conversation

justin-tay
Copy link
Contributor

Modified MockMvcHttpConnector to set sameSite using Cookie.getAttribute.

The test relies on MockCookie setting the SameSite attribute to pass.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 1, 2023
@sbrannen sbrannen changed the title Support SameSite attribute in MockMvcHttpConnector Support SameSite cookie attribute in MockMvcHttpConnector Apr 1, 2023
@sbrannen sbrannen self-assigned this Apr 1, 2023
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement status: blocked An issue that's blocked on an external project change labels Apr 1, 2023
@sbrannen
Copy link
Member

sbrannen commented Apr 1, 2023

@sbrannen sbrannen added this to the 6.0.8 milestone Apr 1, 2023
@sbrannen sbrannen added in: test Issues in the test module and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 1, 2023
@sbrannen sbrannen mentioned this pull request Apr 1, 2023
Closed
@sbrannen sbrannen removed the status: blocked An issue that's blocked on an external project change label Apr 4, 2023
@sbrannen sbrannen mentioned this pull request Apr 4, 2023
Closed
3 tasks
@sbrannen
Copy link
Member

sbrannen commented Apr 4, 2023

FYI: this PR inspired me to create #30285.

So thanks for that. 👍

@sbrannen sbrannen closed this in dd97ee4 Apr 4, 2023
@sbrannen
Copy link
Member

sbrannen commented Apr 4, 2023

This has been merged into main.

Thanks

mdeinum pushed a commit to mdeinum/spring-framework that referenced this pull request Jun 29, 2023
@justin-tay @mdeinum
Support SameSite cookie attribute in MockMvcHttpConnector
0b0145f 
Closes spring-projectsgh-30264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justin-tay @sbrannen @spring-projects-issues