-
Notifications
You must be signed in to change notification settings - Fork 38.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent confusion about build(boolean) method in UriComponentsBuilder #25604
Conversation
To prevent confusion about the build(boolean) method
@eitan613 I'm fine to make some Javadoc improvements but I'm not sure if the proposed change makes much of a difference. Either way the I was thinking rather that the Or otherwise please clarify what confused you so we can find a way to improve. |
@rstoyanchev truth be told I wasn't really using this code and after looking at it a bit I wasn't really confused about it. I noticed that others were, the user who opened up issue #25444 for example, and when I looked around online it seems others were confused also. It sounds to me like the change about the |
Okay I see. I think it already says that but we can certainly strengthen the language used. It does sound more like the confusion might be from looking at the method and assuming what it means. |
Anything else I can/should do then? |
To prevent confusion about the build(boolean) method