FileUrlResource isWritable method returns true if URL protocol is not indicating a file #25584
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if add testcase
@Test void test() throws IOException { Resource resource = new FileUrlResource(new URL("https://spring.io/")); assertThat(resource.isReadable()).isFalse(); }
the former code cannot pass.
Then I restricted FileUrlResource must be contructed with a URL about file.